fix: nxlog use time field as signal if missing #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/nxlog_test.py
Outdated
| @@ -52,16 +52,14 @@ def test_nxobject_log(h5root): | |||
| assert sc.identical(log[...], da) | |||
|
|
|||
|
|
|||
| @pytest.mark.filterwarnings("ignore:Failed to load /entry/log:UserWarning") | |||
| def test_nxlog_with_missing_value_triggers_fallback(nxroot): | |||
src/scippnexus/nxdata.py
Outdated
Comment on lines
489
to
497
| fallback_signal_name='value', | ||
| ) | ||
|
|
||
| def _init_signal(self, *args, children, **kwargs): | ||
| super()._init_signal(*args, children=children, **kwargs) | ||
| if self._signal is None: | ||
| if 'time' in children: | ||
| self._signal_name = 'time' | ||
| self._signal = children['time'] |
There was a problem hiding this comment.
Could this simply use
fallback_signal_name='value' if 'value' in children else 'time'`?
There was a problem hiding this comment.
But, there's no argument to _init_signal called fallback_signal_name
There was a problem hiding this comment.
My point was to change __init__ and remove _init_signal.
jokasimr
force-pushed
the
remove-warn-tdc
branch
from
2951e32
to
0e64b44
Compare
SimonHeybrock
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #230